mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <an...@apache.org>
Subject Re: Review Request 55940: Added support for the new streaming request/response headers.
Date Thu, 26 Jan 2017 04:51:39 GMT


> On Jan. 26, 2017, 12:58 a.m., Vinod Kone wrote:
> > src/slave/containerizer/mesos/io/switchboard.cpp, lines 1299-1322
> > <https://reviews.apache.org/r/55940/diff/1/?file=1615314#file1615314line1299>
> >
> >     Not yours, but I'm wondering if these should be CHECKs because the agent API
handler already validates these.

Good catch! Added another review in the chain to make the as explicit assertions.


> On Jan. 26, 2017, 12:58 a.m., Vinod Kone wrote:
> > src/slave/http.cpp, line 374
> > <https://reviews.apache.org/r/55940/diff/1/?file=1615315#file1615315line374>
> >
> >     do you have to cast here?

Yeah, we need to add an assignment operator for `Option<T>` from a `T&&`.


- Anand


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55940/#review163057
-----------------------------------------------------------


On Jan. 25, 2017, 7:48 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55940/
> -----------------------------------------------------------
> 
> (Updated Jan. 25, 2017, 7:48 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-6936
>     https://issues.apache.org/jira/browse/MESOS-6936
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Modified the Agent API/Switchboard handlers to support the
> "Message-Accept"/"Message-Content-Type" headers for request/response
> streaming. Also, adds general validations to ensure that non-streaming
> requests/responses don't have these headers set.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/io/switchboard.cpp 1b8f490872b8a13dc7bc64883ed28080752f82b6

>   src/slave/http.cpp 85990aee42195f8d2e0affa06c0bb5724f229247 
>   src/slave/slave.hpp 0dadbe50be15f89b791da55fa10f1b434693ee0f 
> 
> Diff: https://reviews.apache.org/r/55940/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message