mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <>
Subject Re: Review Request 55954: Changed 'Environment.Variable.Value' from required to optional.
Date Thu, 26 Jan 2017 02:36:42 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Jan. 26, 2017, 2:36 a.m.)

Review request for mesos, Jan Schlicht and Vinod Kone.

Bugs: MESOS-6991

Repository: mesos


To prepare for future work which will enable the
modular fetching of secrets, we should change the
Environment.Variable.Value field from required to
optional. This way, the field can be left empty
and filled in by a secret fetching module.

Diffs (updated)

  include/mesos/mesos.proto 044b7e697f77c9e2cefb938bda4307d328b33766 
  include/mesos/v1/mesos.proto 7706de89d91926aedb10e4c882dffcf050f03bb1 
  src/checks/checker.cpp 8d7285af40d9633608178ec239d3b8d65d3a2725 
  src/checks/health_checker.cpp e70bd7936752613a4f92c70c4c61cd7cdf7c4ee5 
  src/common/validation.hpp fee955139d9699caa651d9bbd03342f2eba8143f 
  src/common/validation.cpp b2548ad87b4227d6e498c49b5694acb362f6281b 
  src/master/validation.cpp e3f71be16ff21a1b4e10ad59846d9b06691bc1b9 
  src/slave/validation.cpp 3fd32feb3cd0e6d30a66a917e20fd9ca50b84dc2 



Testing information at the end of this review chain.


Greg Mann

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message