mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 55941: Modified existing tests to support new headers for request streaming.
Date Thu, 26 Jan 2017 01:11:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55941/#review163065
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/api_tests.cpp (line 4572)
<https://reviews.apache.org/r/55941/#comment234499>

    headers



src/tests/api_tests.cpp (line 4757)
<https://reviews.apache.org/r/55941/#comment234500>

    you wanted to test the backwards compatibility here? i.e., setting accept to "application/json"
and not "application/recordio".


- Vinod Kone


On Jan. 25, 2017, 7:49 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55941/
> -----------------------------------------------------------
> 
> (Updated Jan. 25, 2017, 7:49 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-6936
>     https://issues.apache.org/jira/browse/MESOS-6936
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> These tests now set the "Message-Accept", "Message-Content-Type"
> headers correctly for streaming responses/requests.
> 
> 
> Diffs
> -----
> 
>   src/tests/api_tests.cpp 400ac6fcd420508509291249cad50679fbe9807d 
>   src/tests/containerizer/io_switchboard_tests.cpp 2e3cfe5003defdb5c46e770b54199d36be03c804

> 
> Diff: https://reviews.apache.org/r/55941/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message