mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 55940: Added support for the new streaming request/response headers.
Date Thu, 26 Jan 2017 00:58:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55940/#review163057
-----------------------------------------------------------




src/slave/containerizer/mesos/io/switchboard.cpp (lines 1299 - 1320)
<https://reviews.apache.org/r/55940/#comment234496>

    Not yours, but I'm wondering if these should be CHECKs because the agent API handler already
validates these.



src/slave/containerizer/mesos/io/switchboard.cpp (line 1668)
<https://reviews.apache.org/r/55940/#comment234498>

    move this to #1672



src/slave/http.cpp (line 372)
<https://reviews.apache.org/r/55940/#comment234486>

    do you have to cast here?



src/slave/http.cpp (line 412)
<https://reviews.apache.org/r/55940/#comment234493>

    Can you add a comment here
    
    // For backwards compatibility, if a client does not specify an 'Accept' header,
    // 'Content-Type' of the response is set to 'application/json' both for
    // non-streaming and streaming responses.
    //
    // TODO(Anand): In v2 API, the default 'Content-Type' for streaming responses should
    // be 'application/recordio'.



src/slave/http.cpp (line 440)
<https://reviews.apache.org/r/55940/#comment234488>

    should this be `NotAcceptable` instead?


- Vinod Kone


On Jan. 25, 2017, 7:48 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55940/
> -----------------------------------------------------------
> 
> (Updated Jan. 25, 2017, 7:48 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-6936
>     https://issues.apache.org/jira/browse/MESOS-6936
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Modified the Agent API/Switchboard handlers to support the
> "Message-Accept"/"Message-Content-Type" headers for request/response
> streaming. Also, adds general validations to ensure that non-streaming
> requests/responses don't have these headers set.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/io/switchboard.cpp 1b8f490872b8a13dc7bc64883ed28080752f82b6

>   src/slave/http.cpp 85990aee42195f8d2e0affa06c0bb5724f229247 
>   src/slave/slave.hpp 0dadbe50be15f89b791da55fa10f1b434693ee0f 
> 
> Diff: https://reviews.apache.org/r/55940/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message