mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 55954: Changed 'Environment.Variable.Value' from required to optional.
Date Wed, 25 Jan 2017 23:54:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55954/#review163046
-----------------------------------------------------------



Looks like you missed validation in a few other places:

ExecutorInfo.CommandInfo
LaunchNestedContainer.CommandInfo
LaunchNestedContainerSession.CommandInfo
CheckInfo.CommandInfo


src/common/validation.cpp (line 90)
<https://reviews.apache.org/r/55954/#comment234477>

    do you need this if statement?



src/common/validation.cpp (lines 94 - 96)
<https://reviews.apache.org/r/55954/#comment234478>

    how about:
    
    return Error("Environment variable '" + variable.name() + "' must have a value set");



src/health-check/health_checker.cpp (line 676)
<https://reviews.apache.org/r/55954/#comment234479>

    you would also need to add validation for regular checks, not just health checks. 
    
    looks like you didn't update your master branch? this file is now under "src/checks".


- Vinod Kone


On Jan. 25, 2017, 8:10 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55954/
> -----------------------------------------------------------
> 
> (Updated Jan. 25, 2017, 8:10 p.m.)
> 
> 
> Review request for mesos, Jan Schlicht and Vinod Kone.
> 
> 
> Bugs: MESOS-6991
>     https://issues.apache.org/jira/browse/MESOS-6991
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> To prepare for future work which will enable the
> modular fetching of secrets, we should change the
> Environment.Variable.Value field from required to
> optional. This way, the field can be left empty
> and filled in by a secret fetching module.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 8f14444d6957a97eff1e0a94817d38e7a7de6d69 
>   include/mesos/v1/mesos.proto 74e7851b147ab821dceeab6e838d34b092f101c3 
>   src/common/validation.hpp fee955139d9699caa651d9bbd03342f2eba8143f 
>   src/common/validation.cpp b2548ad87b4227d6e498c49b5694acb362f6281b 
>   src/health-check/health_checker.cpp a8424b75927d15dc1b897faf0e47cf075c70ff26 
>   src/master/validation.cpp 5f134b781901f2de6a90fa6a10d42cc7629c27a0 
> 
> Diff: https://reviews.apache.org/r/55954/diff/
> 
> 
> Testing
> -------
> 
> Testing information at the end of this review chain.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message