mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Review Request 55955: Added validation tests to ensure environment variable value is set.
Date Wed, 25 Jan 2017 20:13:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55955/
-----------------------------------------------------------

Review request for mesos, Jan Schlicht and Vinod Kone.


Bugs: MESOS-6991
    https://issues.apache.org/jira/browse/MESOS-6991


Repository: mesos


Description
-------

The `value` field within `Environment::Variable` is being
changed to `optional`, but for the time being we will
enforce that it must be set for backward compatibility.
This patch adds tests to ensure that environment variables
with unset values are correctly rejected.


Diffs
-----

  src/tests/health_check_tests.cpp 0a6d2dd295408dcc0434f3573e307e685f9abfe4 
  src/tests/master_validation_tests.cpp a63178139a5283d6a3fcbe60c271dab1914e5da9 

Diff: https://reviews.apache.org/r/55955/diff/


Testing
-------

bin/mesos-tests.sh --gtest_filter="*Validation*"


Thanks,

Greg Mann


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message