mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 55911: Fixed flakiness in TaskValidationTest.TaskReusesUnreachableTaskID.
Date Wed, 25 Jan 2017 19:31:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55911/#review163007
-----------------------------------------------------------


Ship it!




If I understand this correctly, the test is failing (when run as ROOT) because:

* Agent 1 starts a container.
* Agent 1 is partitioned.
* Agent 2 starts.
* Agent 2 observes (via global cgroups) Agent 1's container as an orphan.
* Agent 2 kills Agent 1's container.
* During test teardown, Agent 1 tries to clean up the container destroyed by Agent 2, fails.

To fix this, you are simply cleaning up Agent 1 after you've partitioned it, as it doesn't
come back during the lifetime of the test anyway.  Can you add something like this to the
review description?

- Joseph Wu


On Jan. 24, 2017, 6:38 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55911/
> -----------------------------------------------------------
> 
> (Updated Jan. 24, 2017, 6:38 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-6983
>     https://issues.apache.org/jira/browse/MESOS-6983
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed flakiness in TaskValidationTest.TaskReusesUnreachableTaskID.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_validation_tests.cpp ce10ea4502d0a13faca28d288dd16cd5cb864f6e 
> 
> Diff: https://reviews.apache.org/r/55911/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> Without this change, this test fails on most platforms in the internal CI. With this
change, no failures of this test are observed.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message