mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 55571: Changed Master::Framework::updateFrameworkInfo so it can return errors.
Date Wed, 25 Jan 2017 07:33:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55571/
-----------------------------------------------------------

(Updated Jan. 25, 2017, 8:33 a.m.)


Review request for mesos, Benjamin Mahler, Jay Guo, Guangya Liu, and Michael Park.


Changes
-------

Added more logging.


Bugs: MESOS-6631
    https://issues.apache.org/jira/browse/MESOS-6631


Repository: mesos


Description
-------

This allows us to confirm that an updated FrameworkInfo is fully
compatible with an already known one. By performing this check in
updateFrameworkInfo when can be sure that both the new and old
FrameworkInfo are available (e.g., after framework reregistration, or
master or framework failover).


Diffs (updated)
-----

  src/master/master.hpp 4bd01fd21820b7cdb6c2a23436d50e00fbbd5849 
  src/master/master.cpp d2aee2b6e2a5da776c3b046a228d5ffcabd1bd54 

Diff: https://reviews.apache.org/r/55571/diff/


Testing
-------

Tested as part of https://reviews.apache.org/r/55271/.


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message