mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Review Request 55910: Prevent unintended mutation in the allocator.
Date Wed, 25 Jan 2017 02:40:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55910/
-----------------------------------------------------------

Review request for mesos and Michael Park.


Repository: mesos


Description
-------

Currently, a lof of code in the allocator makes use of the `[]`
operator to access the agents, frameworks and sorters, which
can lead to subtle bugs where insertion was unintended.

With this change, a few const functions can be marked as such.


Diffs
-----

  src/master/allocator/mesos/hierarchical.hpp 9b66c23f26b37c02ed850c06c4518ea99078b02d 
  src/master/allocator/mesos/hierarchical.cpp c2211be7458755aeb91ef078e4bfe92ac474044a 

Diff: https://reviews.apache.org/r/55910/diff/


Testing
-------

make check


Thanks,

Benjamin Mahler


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message