mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 55607: CMake: Added configuration of test scripts in the bin/ directory.
Date Wed, 25 Jan 2017 01:07:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55607/#review162888
-----------------------------------------------------------




cmake/MesosConfigure.cmake (line 212)
<https://reviews.apache.org/r/55607/#comment234269>

    This part ( https://cmake.org/cmake/help/v3.0/command/configure_file.html ): ```
    If the <input> file is modified the build system will re-run CMake to re-configure
the file and generate the build system again.
    ```
    
    is a little unfortunate, but that's better than the automake, which doesn't always regenerate
these template files when the underlying ones get changed.



cmake/MesosConfigure.cmake (line 215)
<https://reviews.apache.org/r/55607/#comment234271>

    Perhaps add a comment that `@ONLY` prevents us from substituting some value for `${@}`,
which we commonly use in our template scripts.



cmake/MesosConfigure.cmake (line 217)
<https://reviews.apache.org/r/55607/#comment234270>

    How about moving the file instead?  And cleaning up the bin/tmp folder?


- Joseph Wu


On Jan. 17, 2017, 12:34 a.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55607/
> -----------------------------------------------------------
> 
> (Updated Jan. 17, 2017, 12:34 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.
> 
> 
> Bugs: MESOS-6757
>     https://issues.apache.org/jira/browse/MESOS-6757
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This resolves MESOS-6757.
> 
> 
> Diffs
> -----
> 
>   cmake/MesosConfigure.cmake 6a9ed9dc02f5c9a6d1fce0866f19ffeafec35cdc 
> 
> Diff: https://reviews.apache.org/r/55607/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message