mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 55271: Disallow multi-role frameworks to change their roles.
Date Wed, 25 Jan 2017 00:41:29 GMT


> On Jan. 14, 2017, 10:04 p.m., Guangya Liu wrote:
> > src/tests/master_validation_tests.cpp, line 2616
> > <https://reviews.apache.org/r/55271/diff/5/?file=1603889#file1603889line2616>
> >
> >     How about s/RejectRolesChange/RejectRolesChangeWithMutiRole
> 
> Benjamin Bannier wrote:
>     When I named the test `RejectRolesChange` instead of `RejectRoleChange` I was hoping
it would already be clear that this test would deal with a multi-role scenario. Was that too
subtle? I would like to avoid excessive redundancy in the test name.
> 
> Michael Park wrote:
>     How about `RejectMultiRolesChange`?
> 
> Benjamin Bannier wrote:
>     Isn't this also highly redundant?
>     
>     I believe going forward we should parameterize these tests to take either some initial
and final `role` or `roles`, and an boolean for whether we expect this migration to pass.
In that cases it would make even sense to name these tests `RolesChange` and `RolesChangeOnMasterFailover`.
I am still unsure on what to do with the `s` in there.

To settle this, I am going with `RejectRoleChangeWithMultiRole` now. I feel this might be
verbose, but less confusing than `RejectMultiRolesChange` (`MULTI_ROLE` vs. roles).


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55271/#review161648
-----------------------------------------------------------


On Jan. 25, 2017, 1:41 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55271/
> -----------------------------------------------------------
> 
> (Updated Jan. 25, 2017, 1:41 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Jay Guo, Guangya Liu, and Michael Park.
> 
> 
> Bugs: MESOS-6631
>     https://issues.apache.org/jira/browse/MESOS-6631
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> We currently do not allow `MULTI_ROLE` frameworks to change their
> roles. This restriction will be lifted later.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp 4bd01fd21820b7cdb6c2a23436d50e00fbbd5849 
>   src/tests/master_validation_tests.cpp ce10ea4502d0a13faca28d288dd16cd5cb864f6e 
> 
> Diff: https://reviews.apache.org/r/55271/diff/
> 
> 
> Testing
> -------
> 
> Tested on various Linux configurations in internal CI.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message