mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Review Request 55895: Add zero byte disk resource support to XFS.
Date Tue, 24 Jan 2017 23:59:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55895/
-----------------------------------------------------------

Review request for mesos, Jie Yu and Jiang Yan Xu.


Bugs: MESOS-5393
    https://issues.apache.org/jira/browse/MESOS-5393


Repository: mesos


Description
-------

Support containers with zero byte disk resources in the XFS
isolator. This works by setting the quota to the minimum amount
(1 block), since the quota system defines 0 as unlimited.


Diffs
-----

  src/slave/containerizer/mesos/isolators/xfs/disk.cpp dd4df86bf90bfa9cbf4664d89274cf3c64c2e374

  src/slave/containerizer/mesos/isolators/xfs/utils.hpp 7602fe3b6ab069db643397418732e773d0417f8a

  src/slave/containerizer/mesos/isolators/xfs/utils.cpp b9d8e7dc999ba3064bee7105eff0f9553d825df8

  src/tests/containerizer/xfs_quota_tests.cpp 0fbaddd68af55c51c106962377be20afa599fb97 

Diff: https://reviews.apache.org/r/55895/diff/


Testing
-------

sudo make check (Fedora 25)


Thanks,

James Peach


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message