mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 55767: Ensured task's check status is delivered with reconciliation updates.
Date Tue, 24 Jan 2017 23:19:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55767/#review162872
-----------------------------------------------------------


Fix it, then Ship it!





src/common/protobuf_utils.cpp (line 256)
<https://reviews.apache.org/r/55767/#comment234238>

    don't think we are putting back ticks around enums.



src/common/protobuf_utils.cpp (line 273)
<https://reviews.apache.org/r/55767/#comment234237>

    ditto. backticks.


- Vinod Kone


On Jan. 20, 2017, 2:52 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55767/
> -----------------------------------------------------------
> 
> (Updated Jan. 20, 2017, 2:52 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman, haosdent huang, and Vinod Kone.
> 
> 
> Bugs: MESOS-6906
>     https://issues.apache.org/jira/browse/MESOS-6906
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/common/protobuf_utils.hpp 6e0201953dfdaef33a6ed4039d3bbbb607e4b379 
>   src/common/protobuf_utils.cpp 0b429267de989f09f76ddc5281890efd8bcb315e 
>   src/master/master.cpp 73159328ce3fd838e02eba0e6a30cf69efc319ba 
> 
> Diff: https://reviews.apache.org/r/55767/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message