mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 55778: Moved check for 'has_parent()' in docker containerizer destroy.
Date Tue, 24 Jan 2017 23:00:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55778/#review162865
-----------------------------------------------------------


Ship it!




Ship It!

- Vinod Kone


On Jan. 24, 2017, 10:24 p.m., Kevin Klues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55778/
> -----------------------------------------------------------
> 
> (Updated Jan. 24, 2017, 10:24 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-6214 and MESOS-6954
>     https://issues.apache.org/jira/browse/MESOS-6214
>     https://issues.apache.org/jira/browse/MESOS-6954
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Ideally, we would do this check as the first thing we do after
> entering this function. However, the containerizer API currently
> requires callers of `launch()` to also call `destroy()` if the launch
> fails (MESOS-6214). As such, putting the check at the top of this
> function would cause the containerizer to crash if the launch failure
> was due to the container having its `parent` field set. Once we remove
> the requirement for `destroy()` to be called explicitly after launch
> failures, we should move this check back to the top of this function.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/docker.cpp cfc67951dc29e4ed804614aeb36b76cf7d499add 
> 
> Diff: https://reviews.apache.org/r/55778/diff/
> 
> 
> Testing
> -------
> 
> GTEST_FILTER="" make -j check
> sudo src/mesos-tests
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message