mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Bruce Merry <>
Subject Re: Review Request 55761: Fixed name matching for automatic resources.
Date Tue, 24 Jan 2017 14:59:19 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Jan. 24, 2017, 2:59 p.m.)

Review request for mesos and Vinod Kone.

Bugs: MESOS-6821

Repository: mesos


Instead of doing a simple substring search for known resources like
"cpus" to decide whether they have been explicitly specified, it now
parses the resource string to check that a resource with that exact
name was specified.

This splits out a fromString static member function from the start of
Resources::parse that does parsing using either fromJSON or
fromSimpleString and makes it available to use in

Fixes MESOS-6821.

Diffs (updated)

  include/mesos/resources.hpp c2e6d6680d9687f0bbfb73e84ffb1457072c4412 
  src/ 3d0e82cb522d379923e00e5e98e9c9f646fdd3db 
  src/common/resources.cpp be9bca2063e9f0e60c5faa0142077bea56272e45 
  src/slave/containerizer/containerizer.cpp d46882baa904fd439bffb23c324828b777228f1c 
  src/tests/containerizer/containerizer_tests.cpp PRE-CREATION 



Regression test added.


Bruce Merry

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message