mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 55856: Displayed unreachable tasks in the webui.
Date Tue, 24 Jan 2017 00:56:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55856/#review162750
-----------------------------------------------------------


Fix it, then Ship it!





src/webui/master/static/home.html (line 104)
<https://reviews.apache.org/r/55856/#comment234059>

    Should this be moved up before `Finished` to be next to other gauges?


- Vinod Kone


On Jan. 23, 2017, 9:34 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55856/
> -----------------------------------------------------------
> 
> (Updated Jan. 23, 2017, 9:34 p.m.)
> 
> 
> Review request for mesos, haosdent huang and Vinod Kone.
> 
> 
> Bugs: MESOS-6389
>     https://issues.apache.org/jira/browse/MESOS-6389
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This commit adds:
> 
> * A count of the total number of unreachable tasks
> * A list of unreachable tasks to the "home" page
> * A list of unreachable tasks to the "framework" page
> 
> In all three cases, we only report unreachable tasks that the master
> knows about. The master only keeps a limited-size cache of unreachable
> tasks for each framework and does not attempt to preserve this
> information across master failover, which means there may be unreachable
> tasks that are not displayed by the webui.
> 
> 
> Diffs
> -----
> 
>   src/webui/master/static/framework.html 6297cf932838ed32c8def1022efda9ef5a053d37 
>   src/webui/master/static/home.html 23b09b67ffb42f7a18012b5e09cfbfb3659d98da 
>   src/webui/master/static/js/controllers.js b6364fa636a6dc4b8d314285bec7dc19eb1c9c3b

> 
> Diff: https://reviews.apache.org/r/55856/diff/
> 
> 
> Testing
> -------
> 
> Visual inspection.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message