mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 54232: Shutdown tasks of completed frameworks on agent re-registration.
Date Tue, 24 Jan 2017 00:54:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54232/
-----------------------------------------------------------

(Updated Jan. 24, 2017, 12:54 a.m.)


Review request for mesos and Vinod Kone.


Changes
-------

Simplify into a single loop, per review suggestion.


Bugs: MESOS-6602
    https://issues.apache.org/jira/browse/MESOS-6602


Repository: mesos


Description
-------

Previously, if a framework completed (e.g., due to a teardown operation
or framework shutdown), any framework tasks running on partitioned
agents would not be shutdown when the agent re-registered. For tasks
that are not partition-aware, the task would be shutdown on agent
re-registration anyway. But for partition-aware tasks, this could lead
to orphan tasks.

Fix this by changing the master to shutdown such tasks when the agent
reregisters.

Note that if the master fails over between the time the framework
completes and a partitioned agent re-registers, any framework tasks
running on the agent will NOT be shutdown. This is a known bug; fixing
it requires persisting the framework shutdown operation to the registry
(MESOS-1719).


Diffs (updated)
-----

  src/master/master.cpp 73159328ce3fd838e02eba0e6a30cf69efc319ba 
  src/tests/partition_tests.cpp e7f64182f39dfdf15d035b43c18bf58aecfc74d1 

Diff: https://reviews.apache.org/r/54232/diff/


Testing
-------

`make check`


Thanks,

Neil Conway


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message