mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 55476: Changed TASK_UNREACHABLE to be a non-terminal state.
Date Tue, 24 Jan 2017 00:33:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55476/#review162735
-----------------------------------------------------------


Ship it!




Ship It!

- Vinod Kone


On Jan. 18, 2017, 7:33 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55476/
> -----------------------------------------------------------
> 
> (Updated Jan. 18, 2017, 7:33 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-6619
>     https://issues.apache.org/jira/browse/MESOS-6619
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This task state was always conceptually non-terminal, but previously
> `isTerminalState` returned true for it. The master now distinguishes
> between "removable" and "terminal" task states, so we can correctly
> classify TASK_UNREACHABLE as a removable but non-terminal task state.
> 
> 
> Diffs
> -----
> 
>   src/common/protobuf_utils.cpp af3c2a660f91c366ca5ffe8671d10c4a270bbbcc 
> 
> Diff: https://reviews.apache.org/r/55476/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message