mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jiang Yan Xu <...@jxu.me>
Subject Re: Review Request 51028: Fix tests with rapidly triggered allocations.
Date Mon, 23 Jan 2017 23:08:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51028/#review162722
-----------------------------------------------------------


Fix it, then Ship it!




Modulo @bmahler's comments.


src/tests/hierarchical_allocator_tests.cpp (line 3764)
<https://reviews.apache.org/r/51028/#comment234047>

    "agents" and "in" can be in one string.



src/tests/hierarchical_allocator_tests.cpp (line 3765)
<https://reviews.apache.org/r/51028/#comment234050>

    Is `s/performing/; performed/?` better?



src/tests/hierarchical_allocator_tests.cpp (line 3768)
<https://reviews.apache.org/r/51028/#comment234053>

    `runs`: If we consider "one allocation is one offercallback", one allocation run generates
many allocations, one per framework.
    
    So s/allocation runs/allocations/


- Jiang Yan Xu


On Jan. 18, 2017, 11:29 p.m., Jacob Janco wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51028/
> -----------------------------------------------------------
> 
> (Updated Jan. 18, 2017, 11:29 p.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-6904
>     https://issues.apache.org/jira/browse/MESOS-6904
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> - Per MESOS-3157, if cluster events with the possibility
>   of triggering an allocation occur rapidly and test
>   assertions depend on gleaning information from assumed
>   order, it is likely they will fail due to lack of parity
>   between event and actual allocation. Ensure that expected
>   allocations occur.
> 
> 
> Diffs
> -----
> 
>   src/tests/hierarchical_allocator_tests.cpp 1edd0ecc8a93cd41532e1cf3641f67c780ab23a5

> 
> Diff: https://reviews.apache.org/r/51028/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jacob Janco
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message