mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 55806: Updated webui to display number of unreachable tasks.
Date Mon, 23 Jan 2017 21:36:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55806/#review162708
-----------------------------------------------------------



On reflection, populating this field from the `unreachable_tasks` metric isn't the best approach,
since (a) we want to use the per-framework `unreachable_tasks` field to report more detailed
information about unreachable tasks, and (b) the metric is computed from (a), anyway. Hence
I'll discard this; new approach is in https://reviews.apache.org/r/55856/

- Neil Conway


On Jan. 21, 2017, 11:27 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55806/
> -----------------------------------------------------------
> 
> (Updated Jan. 21, 2017, 11:27 p.m.)
> 
> 
> Review request for mesos, haosdent huang and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated webui to display number of unreachable tasks.
> 
> 
> Diffs
> -----
> 
>   src/webui/master/static/home.html cf251865e1670beee9532f7c6e1b4dc23e86dbfc 
>   src/webui/master/static/js/controllers.js 388ca2447716cbc7141da6a20daf2340621a16e8

> 
> Diff: https://reviews.apache.org/r/55806/diff/
> 
> 
> Testing
> -------
> 
> `make check`, visual inspection.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message