mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jacob Janco <jjanco....@gmail.com>
Subject Re: Review Request 55791: Rework clipboard functionality in UI.
Date Sun, 22 Jan 2017 18:11:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55791/
-----------------------------------------------------------

(Updated Jan. 22, 2017, 6:11 p.m.)


Review request for mesos and haosdent huang.


Bugs: MESOS-6969
    https://issues.apache.org/jira/browse/MESOS-6969


Repository: mesos


Description
-------

- Use pure js clipboard.js and remove
  flash dependency.
- Vendored zeroclipboard has security issues
  https://www.cvedetails.com/cve/CVE-2014-1869/


Diffs
-----

  src/webui/master/static/css/mesos.css c817aaee0fd2d2579ff2e4a152d47e83ce80d68c 
  src/webui/master/static/index.html a4eda3034906d100a20dcd0a2473112c1edd6b42 
  src/webui/master/static/js/app.js c32177aa23c962f2bdf03d98272fb6d21a565382 
  src/webui/master/static/js/clipboard-1.5.16.js PRE-CREATION 
  src/webui/master/static/js/clipboard-1.5.16.min.js PRE-CREATION 
  src/webui/master/static/js/zeroclipboard-1.1.7.js d45551d6c9f75c275032219768549f76865b9cd3

  src/webui/master/static/js/zeroclipboard-1.1.7.min.js 32535fddf1baab255fcbf5d3d776a0a9ac1447e8

  src/webui/master/static/obj/zeroclipboard-1.1.7.swf 880e64ee7614e224660c6616b4bbb1ee5fab8ec9


Diff: https://reviews.apache.org/r/55791/diff/


Testing (updated)
-------

make check + verification of clipboard functionality


Thanks,

Jacob Janco


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message