mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Park <mp...@apache.org>
Subject Re: Review Request 55571: Changed Master::Framework::updateFrameworkInfo so it can return errors.
Date Sat, 21 Jan 2017 03:05:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55571/#review162534
-----------------------------------------------------------


Fix it, then Ship it!





src/master/master.cpp (lines 2580 - 2581)
<https://reviews.apache.org/r/55571/#comment233839>

    ```cpp
        Try<Nothing> updateFrameworkInfo =
          framework->updateFrameworkInfo(frameworkInfo);
    ```
    
    A few more instances of this below.


- Michael Park


On Jan. 18, 2017, 7:26 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55571/
> -----------------------------------------------------------
> 
> (Updated Jan. 18, 2017, 7:26 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Jay Guo, and Guangya Liu.
> 
> 
> Bugs: MESOS-6631
>     https://issues.apache.org/jira/browse/MESOS-6631
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This allows us to confirm that an updated FrameworkInfo is fully
> compatible with an already known one. By performing this check in
> updateFrameworkInfo when can be sure that both the new and old
> FrameworkInfo are available (e.g., after framework reregistration, or
> master or framework failover).
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp 8e8a9037af11cf95961b6498540a0fd486ed091b 
>   src/master/master.cpp 73159328ce3fd838e02eba0e6a30cf69efc319ba 
> 
> Diff: https://reviews.apache.org/r/55571/diff/
> 
> 
> Testing
> -------
> 
> Tested as part of https://reviews.apache.org/r/55271/.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message