mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 55772: Rejected optimizing if we are working with a libcxx with UB.
Date Sat, 21 Jan 2017 00:23:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55772/
-----------------------------------------------------------

(Updated Jan. 21, 2017, 1:23 a.m.)


Review request for mesos and Till Toenshoff.


Changes
-------

Turned warning into error.


Summary (updated)
-----------------

Rejected optimizing if we are working with a libcxx with UB.


Bugs: MESOS-6606
    https://issues.apache.org/jira/browse/MESOS-6606


Repository: mesos


Description (updated)
-------

See summary.


Diffs (updated)
-----

  3rdparty/libprocess/configure.ac 48e3b14e3a70e8b0dc416c35997e8784d3409772 

Diff: https://reviews.apache.org/r/55772/diff/


Testing
-------

Tested on OS X Sierra with both bundled clang+stdlib and versions close to their HEADs with

    $ autoreconf -fi && ./configure CXX=/usr/bin/clang++
    $ autoreconf -fi && ./configure CXX=clang++  # versions from HEAD

    $ autoreconf -fi && ./configure --enable-optimize CXX=/usr/bin/clang++
    $ autoreconf -fi && ./configure --enable-optimize CXX=clang++  # versions from
HEAD


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message