mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 55699: Stout: Added `host_default_path`.
Date Sat, 21 Jan 2017 00:22:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55699/#review162524
-----------------------------------------------------------


Ship it!




Just for completeness, I'm going to augment the commit message with:
```
This function returns a host-specific value that can be put into the
`PATH` environment variable.  On POSIX, this is a hard-coded string
pointing to several binary directories.  On Windows, this returns
the location of the OS's root directory.
```

- Joseph Wu


On Jan. 18, 2017, 6:06 p.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55699/
> -----------------------------------------------------------
> 
> (Updated Jan. 18, 2017, 6:06 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Stout: Added `host_default_path`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/posix/os.hpp 397c2d6b06ddb607d254eae8258da5151c5f57e0

>   3rdparty/stout/include/stout/windows/os.hpp b4a66ba8ddbc60f7bcc9aad7fef4e158ae3a96d6

> 
> Diff: https://reviews.apache.org/r/55699/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message