mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Review Request 55808: Changed "master/tasks_unreachable" metric from counter to gauge.
Date Sat, 21 Jan 2017 00:03:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55808/
-----------------------------------------------------------

Review request for mesos and Vinod Kone.


Bugs: MESOS-6966
    https://issues.apache.org/jira/browse/MESOS-6966


Repository: mesos


Description
-------

The number of unreachable tasks should be a gauge, because it can
increase and decrease over time. Note that we report the number of
unreachable tasks that the master knows about; this is a subset of the
"true" number of unreachable tasks, because the master only keeps a
limited-size cache of unreachable tasks for each framework.


Diffs
-----

  docs/monitoring.md f32ee40278afea60f8b1a836798d6fe063d1f222 
  src/master/master.hpp 8e8a9037af11cf95961b6498540a0fd486ed091b 
  src/master/master.cpp 73159328ce3fd838e02eba0e6a30cf69efc319ba 
  src/master/metrics.hpp 056d290c1e14a6afd5056873ef7bb07b5892ed32 
  src/master/metrics.cpp 1f049f3794c1bca45d2684cbbec3b08c1a78c494 
  src/tests/partition_tests.cpp e7f64182f39dfdf15d035b43c18bf58aecfc74d1 

Diff: https://reviews.apache.org/r/55808/diff/


Testing
-------

`make check`


Thanks,

Neil Conway


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message