mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jiang Yan Xu <...@jxu.me>
Subject Review Request 55795: Fixed `umountAll` to optionally also clean up mtab.
Date Fri, 20 Jan 2017 23:32:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55795/
-----------------------------------------------------------

Review request for mesos, Gilbert Song, Jie Yu, and James Peach.


Bugs: MESOS-6478
    https://issues.apache.org/jira/browse/MESOS-6478


Repository: mesos


Description
-------

- Without this, Mesos tests leave garbage in /etc/mtab.


Diffs
-----

  src/linux/fs.hpp da49c9ebfa938d169152ed3b6e4df7378711b013 
  src/linux/fs.cpp 913e23317291db164fe6bdf77f3eca146dedec9b 
  src/tests/containerizer/docker_volume_isolator_tests.cpp 4040d36d1dbf4968f62fa593024936858f28b4df

  src/tests/environment.cpp a9e217e8beb5a6aca456ff5379893953cafca135 
  src/tests/persistent_volume_tests.cpp 468a85b4a6ce09592341afd07ce12a03f5fc4f73 

Diff: https://reviews.apache.org/r/55795/diff/


Testing
-------

sudo make check.

Verified that no garbage is left in mtab.


Thanks,

Jiang Yan Xu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message