mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 55381: Added test for framework upgrading to multi-role capability.
Date Fri, 20 Jan 2017 15:36:45 GMT


> On Jan. 19, 2017, 11:45 p.m., Benjamin Mahler wrote:
> > src/tests/master_validation_tests.cpp, lines 2589-2590
> > <https://reviews.apache.org/r/55381/diff/4/?file=1607721#file1607721line2589>
> >
> >     Both empty would signify a change of roles since an empty `roles` indicates
no roles rather than the default role of `"*"`.
> >     
> >     This test appears to be covering the case where they are both set to the same
non-default value (so I'll update the comment), do you want to add another test that covers
the `"*`" case or is the implementation agnostic to this case?

For framework upgrades to multi-role, I was interpreting changes of `role='*'` or `role=''`
to `roles={}` as equivalent in follow-up patches, and I read your comment as that not being
the case. Are the expected upgrade semantics `'*' -> {*}` and `'' -> {}`? If that is
the case, is `{}` considered an error, or would such a framework receives offers for `*` as
well? If `{}` is an error, we seem to be lacking validation for that as well.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55381/#review162351
-----------------------------------------------------------


On Jan. 18, 2017, 4:26 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55381/
> -----------------------------------------------------------
> 
> (Updated Jan. 18, 2017, 4:26 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Jay Guo, and Guangya Liu.
> 
> 
> Bugs: MESOS-6900
>     https://issues.apache.org/jira/browse/MESOS-6900
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_validation_tests.cpp c092362152e1fe8a6b615c2eda171d852c1bbd86 
> 
> Diff: https://reviews.apache.org/r/55381/diff/
> 
> 
> Testing
> -------
> 
> make check (OS X)
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message