-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55761/#review162414
-----------------------------------------------------------
src/tests/containerizer/containerizer_tests.cpp (line 34)
<https://reviews.apache.org/r/55761/#comment233751>
I wasn't sure what to call this class. ContainerizerTest is already taken for tests templated
on the specific containerizer.
- Bruce Merry
On Jan. 20, 2017, 1:01 p.m., Bruce Merry wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55761/
> -----------------------------------------------------------
>
> (Updated Jan. 20, 2017, 1:01 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-6821
> https://issues.apache.org/jira/browse/MESOS-6821
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Instead of doing a simple substring search for known resources like
> "cpus" to decide whether they have been explicitly specified, it now
> parses the resource string to check that a resource with that exact
> name was specified.
>
> This splits out a fromString static member function from the start of
> Resources::parse that does parsing using either fromJSON or
> fromSimpleString and makes it available to use in
> mesos::internal::slave::Containerizer::resources.
>
> Fixes MESOS-6821.
>
>
> Diffs
> -----
>
> include/mesos/resources.hpp c2e6d6680d9687f0bbfb73e84ffb1457072c4412
> src/Makefile.am 3d0e82cb522d379923e00e5e98e9c9f646fdd3db
> src/common/resources.cpp be9bca2063e9f0e60c5faa0142077bea56272e45
> src/slave/containerizer/containerizer.cpp d46882baa904fd439bffb23c324828b777228f1c
> src/tests/containerizer/containerizer_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/55761/diff/
>
>
> Testing
> -------
>
> Regression test added.
>
>
> Thanks,
>
> Bruce Merry
>
>
|