mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 55459: Added task check validation test.
Date Fri, 20 Jan 2017 10:55:10 GMT


> On Jan. 18, 2017, 11:38 a.m., Vinod Kone wrote:
> > src/tests/check_tests.cpp, line 114
> > <https://reviews.apache.org/r/55459/diff/2/?file=1607440#file1607440line114>
> >
> >     Can you also add a test for valid cases?

They are embedded into this test: there are some `EXPECT_NONE`'s. I'll rename the test to
reflect it.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55459/#review162073
-----------------------------------------------------------


On Jan. 18, 2017, 9:31 a.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55459/
> -----------------------------------------------------------
> 
> (Updated Jan. 18, 2017, 9:31 a.m.)
> 
> 
> Review request for mesos, Gastón Kleiman, haosdent huang, and Vinod Kone.
> 
> 
> Bugs: MESOS-6906
>     https://issues.apache.org/jira/browse/MESOS-6906
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 3d0e82cb522d379923e00e5e98e9c9f646fdd3db 
>   src/tests/CMakeLists.txt b7adf4f3126611a57baf4f62b62b208bc0236da5 
>   src/tests/check_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/55459/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message