mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <>
Subject Review Request 55740: Fixed unsafe usage of process pointer in loop.hpp.
Date Fri, 20 Jan 2017 01:34:18 GMT

This is an automatically generated e-mail. To reply, visit:

Review request for mesos, Benjamin Bannier, Benjamin Hindman, and Benjamin Mahler.

Repository: mesos


The `loop(...)` helper spawns a libprocess actor to execute some
lambda (in a loop, of course).  This actor is owned by the
libprocess GC actor, but the body of the `loop` passes a copy of that
pointer into a Future callback.  This will potentially segfault if
the actor terminates outside of the `loop`.

Instead, the `loop` should use the `PID` of the actor.


  3rdparty/libprocess/include/process/loop.hpp 8bd9715246e72474a35a0f1af94c8a5a3e87dd7a 



make check


Joseph Wu

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message