mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 55714: Added fs::magic() mapping function for fs id to fs type mapping.
Date Thu, 19 Jan 2017 23:51:10 GMT


> On Jan. 19, 2017, 11:23 p.m., James Peach wrote:
> > src/linux/fs.hpp, line 244
> > <https://reviews.apache.org/r/55714/diff/1/?file=1608946#file1608946line244>
> >
> >     I get the analogy that leads to `magic`, but I'd prefer that it was named something
more obvious. Maybe `typeName()`?

If you change this name, consider the names of the `FS_MAGIC` constants too. Perhaps `FS_TYPE_XXX`?


- James


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55714/#review162354
-----------------------------------------------------------


On Jan. 19, 2017, 11:33 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55714/
> -----------------------------------------------------------
> 
> (Updated Jan. 19, 2017, 11:33 p.m.)
> 
> 
> Review request for mesos, Avinash sridharan, Jie Yu, James Peach, Timothy Chen, and Jiang
Yan Xu.
> 
> 
> Bugs: MESOS-6958
>     https://issues.apache.org/jira/browse/MESOS-6958
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> A simple uint32_t -> string mapping.
> 
> 
> Diffs
> -----
> 
>   src/linux/fs.hpp da49c9ebfa938d169152ed3b6e4df7378711b013 
>   src/linux/fs.cpp 913e23317291db164fe6bdf77f3eca146dedec9b 
> 
> Diff: https://reviews.apache.org/r/55714/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message