mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 55713: Added linux helper function fs::type() for filesystem id detection.
Date Thu, 19 Jan 2017 23:31:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55713/#review162359
-----------------------------------------------------------




src/linux/fs.hpp (line 161)
<https://reviews.apache.org/r/55713/#comment233721>

    `fstype()` would be a bit more obvious to me, though this is consistent with Mesos style.



src/linux/fs.cpp (line 94)
<https://reviews.apache.org/r/55713/#comment233723>

    In the past I've been told that the caller should add context to the error string, in
which case this should just return `ErrnoError()` and the caller should be responsible for
adding the path.



src/linux/fs.cpp (line 96)
<https://reviews.apache.org/r/55713/#comment233722>

    Why are you truncating the return value? `__fsword_t` can be 8 bytes. Maybe it is worth
defining a cleaner typedef for the fs type?
    
    ```
    typedef fstype_t __fsword_t;
    ```


- James Peach


On Jan. 19, 2017, 6:56 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55713/
> -----------------------------------------------------------
> 
> (Updated Jan. 19, 2017, 6:56 p.m.)
> 
> 
> Review request for mesos, Avinash sridharan, Jie Yu, James Peach, Timothy Chen, and Jiang
Yan Xu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Get filesystem type id by using statfs() from <sys/vfs.h>.
> 
> 
> Diffs
> -----
> 
>   src/linux/fs.hpp da49c9ebfa938d169152ed3b6e4df7378711b013 
>   src/linux/fs.cpp 913e23317291db164fe6bdf77f3eca146dedec9b 
>   src/tests/containerizer/fs_tests.cpp ccdd5967d01abfe4fa7746e3588ff93c6e0fe7e4 
> 
> Diff: https://reviews.apache.org/r/55713/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message