mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 55714: Added fs::magic() mapping function for fs id to fs type mapping.
Date Thu, 19 Jan 2017 23:23:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55714/#review162354
-----------------------------------------------------------




src/linux/fs.hpp (line 152)
<https://reviews.apache.org/r/55714/#comment233704>

    AFAICT `<sys/vfs.>` doesn't contain these constants.



src/linux/fs.hpp (line 153)
<https://reviews.apache.org/r/55714/#comment233705>

    Why do we need the `ifndef` here? On my systems there is no existing header file that
might define these constants, so there should be no need to guard against that.



src/linux/fs.hpp (line 154)
<https://reviews.apache.org/r/55714/#comment233706>

    I think these comments are superfluous since the constants are obvioud given the naming.
Suggest that we remove these comments, which also removes the need for `NOLINT`.



src/linux/fs.hpp (line 244)
<https://reviews.apache.org/r/55714/#comment233708>

    I get the analogy that leads to `magic`, but I'd prefer that it was named something more
obvious. Maybe `typeName()`?



src/linux/fs.cpp (line 100)
<https://reviews.apache.org/r/55714/#comment233711>

    Does Mesos typically pass `uint32_t` by const reference? Personally, I'd pass this by
value.



src/linux/fs.cpp (line 103)
<https://reviews.apache.org/r/55714/#comment233710>

    Can you make this `static const`?


- James Peach


On Jan. 19, 2017, 6:56 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55714/
> -----------------------------------------------------------
> 
> (Updated Jan. 19, 2017, 6:56 p.m.)
> 
> 
> Review request for mesos, Avinash sridharan, Jie Yu, James Peach, Timothy Chen, and Jiang
Yan Xu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> A simple uint32_t -> string mapping.
> 
> 
> Diffs
> -----
> 
>   src/linux/fs.hpp da49c9ebfa938d169152ed3b6e4df7378711b013 
>   src/linux/fs.cpp 913e23317291db164fe6bdf77f3eca146dedec9b 
> 
> Diff: https://reviews.apache.org/r/55714/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message