mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 55458: Added validation for a general check.
Date Thu, 19 Jan 2017 17:27:05 GMT


> On Jan. 18, 2017, 11:33 a.m., Vinod Kone wrote:
> > src/checks/checker.hpp, line 31
> > <https://reviews.apache.org/r/55458/diff/2/?file=1607434#file1607434line31>
> >
> >     This should be
> >     
> >     ```
> >     Option<Error> validate(const CheckInfo& check);
> >     ```

I don't think so, since it lives in `validation` namespace. This is also what we do for health
checks.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55458/#review162067
-----------------------------------------------------------


On Jan. 18, 2017, 9:31 a.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55458/
> -----------------------------------------------------------
> 
> (Updated Jan. 18, 2017, 9:31 a.m.)
> 
> 
> Review request for mesos, Gastón Kleiman, haosdent huang, and Vinod Kone.
> 
> 
> Bugs: MESOS-6906
>     https://issues.apache.org/jira/browse/MESOS-6906
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt c06baf3a926687c7c6161025ae4a534dbae637e4 
>   src/Makefile.am 3d0e82cb522d379923e00e5e98e9c9f646fdd3db 
>   src/checks/checker.hpp PRE-CREATION 
>   src/checks/checker.cpp PRE-CREATION 
>   src/master/validation.hpp 78b70a78536cd850cf56b832b575091b2e115284 
>   src/master/validation.cpp 5f134b781901f2de6a90fa6a10d42cc7629c27a0 
> 
> Diff: https://reviews.apache.org/r/55458/diff/
> 
> 
> Testing
> -------
> 
> See https://reviews.apache.org/r/55459/
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message