mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 55472: Moved `Slave` definitions out-of-line to master.cpp.
Date Thu, 19 Jan 2017 16:48:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55472/#review162306
-----------------------------------------------------------




src/master/master.cpp (lines 8871 - 8873)
<https://reviews.apache.org/r/55472/#comment233638>

    does this not fit in one line?
    
    i know in the headers we sometimes put them on different lines for consistency with closeby
methods, but we don't do that in cpp files.



src/master/master.cpp (lines 8880 - 8882)
<https://reviews.apache.org/r/55472/#comment233639>

    one line?



src/master/master.cpp (line 8891)
<https://reviews.apache.org/r/55472/#comment233637>

    2 lines.


- Vinod Kone


On Jan. 18, 2017, 5 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55472/
> -----------------------------------------------------------
> 
> (Updated Jan. 18, 2017, 5 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-6619
>     https://issues.apache.org/jira/browse/MESOS-6619
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Previously, one of the `Slave` member functions was defined out-of-line,
> but the rest were defined inline; make them all defined out-of-line for
> consistency, and also to allow the function implementations to access
> members of `Master` in the future.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp 8e8a9037af11cf95961b6498540a0fd486ed091b 
>   src/master/master.cpp 73159328ce3fd838e02eba0e6a30cf69efc319ba 
> 
> Diff: https://reviews.apache.org/r/55472/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message