mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gastón Kleiman <gas...@mesosphere.com>
Subject Re: Review Request 55677: Made `AttachContainerOutput/Input` tests use an existing container ID.
Date Thu, 19 Jan 2017 16:20:41 GMT


> On Jan. 19, 2017, 2:23 p.m., Vinod Kone wrote:
> > src/tests/api_tests.cpp, line 4266
> > <https://reviews.apache.org/r/55677/diff/2/?file=1608897#file1608897line4266>
> >
> >     we don't do "Times(1)" since that is the default.
> >     
> >     just do
> >     
> >     ```
> >     EXPECT_CALL(exec, registered(_, _, _, _));
> >     
> >     ```

https://reviews.apache.org/r/55722/


- Gastón


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55677/#review162287
-----------------------------------------------------------


On Jan. 19, 2017, 4:19 p.m., Gastón Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55677/
> -----------------------------------------------------------
> 
> (Updated Jan. 19, 2017, 4:19 p.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rukletsov, Anand Mazumdar, Alexander Rojas,
haosdent huang, and Vinod Kone.
> 
> 
> Bugs: MESOS-6864
>     https://issues.apache.org/jira/browse/MESOS-6864
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> These tests verify that the Agent returns a 500 if the containerizer
> doesn't support the `attach` call.
> 
> This chain refactors those methods and make them return a 404 instead of
> a 500 if the container can't be found, so we need to pass the ID of an
> existing container.
> 
> 
> Diffs
> -----
> 
>   src/tests/api_tests.cpp ea62226fbc5dd0bcc5ea60d1bbcd3748f9367467 
> 
> Diff: https://reviews.apache.org/r/55677/diff/
> 
> 
> Testing
> -------
> 
> `make check` in macOS and Linux.
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message