mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <an...@apache.org>
Subject Re: Review Request 55677: Made `AttachContainerOutput/Input` tests use an existing container ID.
Date Thu, 19 Jan 2017 15:19:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55677/#review162293
-----------------------------------------------------------


Fix it, then Ship it!




Modulo comments from Vinod.


src/tests/api_tests.cpp (line 4248)
<https://reviews.apache.org/r/55677/#comment233627>

    Nit: Remove this? You don't need to ignore subsequent offers as there won't be any due
to your task never reaching a terminal state before the driver was stopped.



src/tests/api_tests.cpp (line 4334)
<https://reviews.apache.org/r/55677/#comment233628>

    Ditto as above.


- Anand Mazumdar


On Jan. 19, 2017, 10:17 a.m., Gastón Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55677/
> -----------------------------------------------------------
> 
> (Updated Jan. 19, 2017, 10:17 a.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rukletsov, Anand Mazumdar, Alexander Rojas,
haosdent huang, and Vinod Kone.
> 
> 
> Bugs: MESOS-6864
>     https://issues.apache.org/jira/browse/MESOS-6864
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> These tests verify that the Agent returns a 500 if the containerizer
> doesn't support the `attach` call.
> 
> This chain refactors those methods and make them return a 404 instead of
> a 500 if the container can't be found, so we need to pass the ID of an
> existing container.
> 
> 
> Diffs
> -----
> 
>   src/tests/api_tests.cpp ea62226fbc5dd0bcc5ea60d1bbcd3748f9367467 
> 
> Diff: https://reviews.apache.org/r/55677/diff/
> 
> 
> Testing
> -------
> 
> `make check` in macOS and Linux.
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message