mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Clemmer <clemmer.alexan...@gmail.com>
Subject Review Request 55696: CMake: Separated Mesos system headers from Mesos API headers.
Date Thu, 19 Jan 2017 01:23:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55696/
-----------------------------------------------------------

Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.


Bugs: MESOS-3932
    https://issues.apache.org/jira/browse/MESOS-3932


Repository: mesos


Description
-------

MESOS-3932 specifies a bug that causes spurious warnings to be printed
when building Mesos.

Many of these warnings can be eliminated simply by correctly marking off
the third-party dependencies as `SYSTEM` headers when we specify the
include path.

This commit will thus separate out the headers of Mesos's
third-party dependencies from the core Mesos API headers, and
include them as `SYSTEM` headers.

Notably, we choose to include Stout's and Libprocess's headers as
third-party system headers, since the goal is for them to be completely
independent projects.


Diffs
-----

  src/CMakeLists.txt ce71afc73f85a70cd8f97a6e913662ff7ef0d94c 
  src/docker/CMakeLists.txt 892370d603d42b649afbf05deece5e0b1d97ee98 
  src/master/CMakeLists.txt a9fb34fc7099f05e279ee0506dd18bc0745d546c 
  src/master/cmake/MasterConfigure.cmake 3d316d6ff2910fc360b0faecb5e6ac9687a77883 
  src/slave/CMakeLists.txt 03466bda934290ce41fa6408d35ccae10c9a6f32 
  src/slave/cmake/AgentConfigure.cmake 1582127ccce773af6031a5b09252192b05a13cdc 
  src/tests/CMakeLists.txt b7adf4f3126611a57baf4f62b62b208bc0236da5 
  src/tests/cmake/MesosTestsConfigure.cmake 8d416388a8e45a2832ae3841b58541ba5b0613bc 

Diff: https://reviews.apache.org/r/55696/diff/


Testing
-------


Thanks,

Alex Clemmer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message