mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 55328: Windows: Added passing GC tests to the build.
Date Wed, 18 Jan 2017 23:08:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55328/#review162204
-----------------------------------------------------------


Ship it!





src/tests/gc_tests.cpp (lines 376 - 378)
<https://reviews.apache.org/r/55328/#comment233469>

    Spacing here.  I can fix this up.


- Joseph Wu


On Jan. 8, 2017, 3:53 p.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55328/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2017, 3:53 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.
> 
> 
> Bugs: MESOS-6707
>     https://issues.apache.org/jira/browse/MESOS-6707
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This issue resolves MESOS-6707. See #55327 for the resolution that
> allows us to light up the tests; essentially, we resolved a bug in the
> Windows implementation of `os::rmdir` that causes the Agent sandbox
> deletion to error out instead of completing successfully.
> 
> 
> Diffs
> -----
> 
>   src/tests/gc_tests.cpp c4841e85f785189681e218df714cac2038d77803 
> 
> Diff: https://reviews.apache.org/r/55328/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message