mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Clemmer <clemmer.alexan...@gmail.com>
Subject Re: Review Request 55311: Added `process::initialize` to default executor's `main`.
Date Wed, 18 Jan 2017 18:37:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55311/
-----------------------------------------------------------

(Updated Jan. 18, 2017, 6:37 p.m.)


Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.


Changes
-------

Address Joseph's comments.


Repository: mesos


Description
-------

The default executor's `main` currently depends on `UPID`, which
networking libraries to do things like retrieve the address of the
current host. On Windows, this means that it is required to initialize
the winsock stack to be initialized before `UPID` is used.

To resolve this issue, we add a call to `process::initialize` at the
beginning of the `main`, which will cause the stack to be initialized
correctly.


Diffs (updated)
-----

  src/launcher/default_executor.cpp 57e4799e750f8f5352a9fec58af40efe432ea865 

Diff: https://reviews.apache.org/r/55311/diff/


Testing
-------


Thanks,

Alex Clemmer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message