mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gastón Kleiman <gas...@mesosphere.com>
Subject Re: Review Request 55464: Made the Agent API able to handle containers nested at arbitrary levels.
Date Wed, 18 Jan 2017 14:48:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55464/
-----------------------------------------------------------

(Updated Jan. 18, 2017, 2:48 p.m.)


Review request for mesos, Adam B, Alexander Rukletsov, Anand Mazumdar, Alexander Rojas, haosdent
huang, and Vinod Kone.


Changes
-------

Addressed Anand's feedback.


Bugs: MESOS-6864
    https://issues.apache.org/jira/browse/MESOS-6864


Repository: mesos


Description
-------

Made the Agent API able to handle containers nested at arbitrary levels.


Diffs (updated)
-----

  src/slave/http.cpp ee7119179a6ddd935c3f43a618ef645619c305ee 
  src/slave/slave.cpp ae183e6b8b40094b4764525a6d63164f210ef9d8 
  src/tests/api_tests.cpp ea62226fbc5dd0bcc5ea60d1bbcd3748f9367467 

Diff: https://reviews.apache.org/r/55464/diff/


Testing
-------

`GTEST_FILTER="" make -j 8 check` in macOS.
`make check` in Linux.

I also did some manual testing using a proof of concept  that makes the `DefaultExecutor`
leverage this change to perform CMD health checks.


Thanks,

Gastón Kleiman


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message