mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 55491: Added a `support/README.md` and the `support/jenkins` directory.
Date Wed, 18 Jan 2017 12:50:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55491/#review162080
-----------------------------------------------------------




support/README.md (line 1)
<https://reviews.apache.org/r/55491/#comment233330>

    > # Supporting tools



support/README.md (lines 5 - 7)
<https://reviews.apache.org/r/55491/#comment233329>

    > The scripts directly in this directory are intended to be used by Mesos developers,
while the build scripts in [`jenkins`](jenkins) are used by the ASF Jenkins CI in a bot-specific
way.



support/jenkins/README.md (lines 5 - 6)
<https://reviews.apache.org/r/55491/#comment233331>

    > The scripts named `<name>.sh` correspond to Jenkins jobs named ...



support/jenkins/buildbot.sh (line 22)
<https://reviews.apache.org/r/55491/#comment233332>

    Any reason this isn't named `MESOS_DIRECTORY` like similar variables in other places?



support/jenkins/buildbot.sh (line 25)
<https://reviews.apache.org/r/55491/#comment233336>

    Note sure it would be desirable to forcibly continue with the rest of the script if `pip`
returns an error.
    
    Note that `pip` would return `0` if `virtualenv` were already present.



support/jenkins/reviewbot.sh (line 32)
<https://reviews.apache.org/r/55491/#comment233337>

    Hardcoding a password here seems like a pretty bad idea. Could we instead pass it in from
the outside, e.g., via an environment variable?
    
    We very likely also need to soon change this password now since it is known to everybody.



support/jenkins/tidybot.sh (line 22)
<https://reviews.apache.org/r/55491/#comment233338>

    `MESOS_DIRECTORY`?


- Benjamin Bannier


On Jan. 18, 2017, 10:04 a.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55491/
> -----------------------------------------------------------
> 
> (Updated Jan. 18, 2017, 10:04 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   support/README.md PRE-CREATION 
>   support/jenkins/README.md PRE-CREATION 
>   support/jenkins/buildbot.sh PRE-CREATION 
>   support/jenkins/reviewbot.sh PRE-CREATION 
>   support/jenkins/tidybot.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/55491/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message