mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 55611: Paused the status update manager in `Slave::initialize()`.
Date Wed, 18 Jan 2017 12:33:32 GMT


> On Jan. 18, 2017, 7:49 a.m., Greg Mann wrote:
> > src/slave/slave.cpp, lines 557-560
> > <https://reviews.apache.org/r/55611/diff/1/?file=1606500#file1606500line557>
> >
> >     Should we add a test that fails without this patch, i.e. one in which the agent
drops a status update which is generated during agent initialization/recovery?

While agent does drop an update generated during recovery without this patch, it will eventually
send that update after it registers. So it would be hard to write a test. Let me know if you
have concrete ideas.


- Vinod


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55611/#review162038
-----------------------------------------------------------


On Jan. 17, 2017, 11:22 a.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55611/
> -----------------------------------------------------------
> 
> (Updated Jan. 17, 2017, 11:22 a.m.)
> 
> 
> Review request for mesos and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This is done so that any updates that the status update manager
> receives while the agent is in recovery (e.g., executor terminated)
> are not un-necessarily forwarded to and dropped by the agent.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp ae183e6b8b40094b4764525a6d63164f210ef9d8 
> 
> Diff: https://reviews.apache.org/r/55611/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message