mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 55459: Added task check validation test.
Date Wed, 18 Jan 2017 11:38:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55459/#review162073
-----------------------------------------------------------




src/tests/check_tests.cpp (line 31)
<https://reviews.apache.org/r/55459/#comment233324>

    s/CheckInfoProtobufValidation/Invalid/



src/tests/check_tests.cpp (line 37)
<https://reviews.apache.org/r/55459/#comment233321>

    s/checkProto/check/
    
    or
    
    s/checkProto/checkInfo/



src/tests/check_tests.cpp (line 40)
<https://reviews.apache.org/r/55459/#comment233323>

    I prefer actually doing an equality check on the actual error string, to make sure the
validation is failing for the reason you are expecting. While doing an equality on string
is brittle, I think it is worth it.
    
    Here and below.



src/tests/check_tests.cpp (line 47)
<https://reviews.apache.org/r/55459/#comment233322>

    // The associated message for a given type must be set.



src/tests/check_tests.cpp (line 114)
<https://reviews.apache.org/r/55459/#comment233325>

    Can you also add a test for valid cases?


- Vinod Kone


On Jan. 18, 2017, 9:31 a.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55459/
> -----------------------------------------------------------
> 
> (Updated Jan. 18, 2017, 9:31 a.m.)
> 
> 
> Review request for mesos, Gastón Kleiman, haosdent huang, and Vinod Kone.
> 
> 
> Bugs: MESOS-6906
>     https://issues.apache.org/jira/browse/MESOS-6906
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 3d0e82cb522d379923e00e5e98e9c9f646fdd3db 
>   src/tests/CMakeLists.txt b7adf4f3126611a57baf4f62b62b208bc0236da5 
>   src/tests/check_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/55459/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message