mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 55457: Added protobufs for a general check.
Date Wed, 18 Jan 2017 11:02:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55457/#review162062
-----------------------------------------------------------




include/mesos/mesos.proto (lines 412 - 413)
<https://reviews.apache.org/r/55457/#comment233305>

    See my comments earlier in the chain.



include/mesos/mesos.proto (lines 416 - 417)
<https://reviews.apache.org/r/55457/#comment233306>

    See my comments earlier in the chain.



include/mesos/mesos.proto (line 421)
<https://reviews.apache.org/r/55457/#comment233308>

    What does "empty result" mean exactly? I think we have to be more specific here.



include/mesos/mesos.proto (lines 1723 - 1725)
<https://reviews.apache.org/r/55457/#comment233309>

    We should say that `type` must be set and one of `command` and `http` must be set. And
if the result of the check is not available (e.g., time out), `exit_code` or `status_code`
will be unset.



include/mesos/mesos.proto (line 1809)
<https://reviews.apache.org/r/55457/#comment233311>

    looks like the enums here are alphabetically ordered.



include/mesos/mesos.proto (line 1840)
<https://reviews.apache.org/r/55457/#comment233313>

    Shouldn't we also specify that this will contain the last known value if the update is
triggered for a different reason than REASON_TASK_CHECK_STATUS_UPDATED ?



include/mesos/mesos.proto (lines 1843 - 1845)
<https://reviews.apache.org/r/55457/#comment233310>

    I don't think you need the last sentence. That's an implementation detail.


- Vinod Kone


On Jan. 18, 2017, 9:31 a.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55457/
> -----------------------------------------------------------
> 
> (Updated Jan. 18, 2017, 9:31 a.m.)
> 
> 
> Review request for mesos, Gastón Kleiman, haosdent huang, and Vinod Kone.
> 
> 
> Bugs: MESOS-6906
>     https://issues.apache.org/jira/browse/MESOS-6906
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 8f14444d6957a97eff1e0a94817d38e7a7de6d69 
>   include/mesos/type_utils.hpp 7824407a6bbfc06edeec69479ed82cabae34a440 
>   include/mesos/v1/mesos.proto 74e7851b147ab821dceeab6e838d34b092f101c3 
>   src/common/type_utils.cpp 8270f808277d84a73823992c639d6536a99353b8 
> 
> Diff: https://reviews.apache.org/r/55457/diff/
> 
> 
> Testing
> -------
> 
> See https://reviews.apache.org/r/55459/
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message