mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 55454: Ensured zero health check timeout means infinite timeout.
Date Wed, 18 Jan 2017 10:20:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55454/#review162056
-----------------------------------------------------------


Ship it!




Ship It!

- Vinod Kone


On Jan. 18, 2017, 9:31 a.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55454/
> -----------------------------------------------------------
> 
> (Updated Jan. 18, 2017, 9:31 a.m.)
> 
> 
> Review request for mesos, Gastón Kleiman, haosdent huang, and Vinod Kone.
> 
> 
> Bugs: MESOS-6908
>     https://issues.apache.org/jira/browse/MESOS-6908
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Prior to this patch, zero health check timeout was interpreted
> literally, which is not very helpful since a health check did not
> even get a chance to finish. This patch fixes this behaviour by
> interpreting zero as `Duration::max()` effectively rendering the
> timeout infinite.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 8f14444d6957a97eff1e0a94817d38e7a7de6d69 
>   include/mesos/v1/mesos.proto 74e7851b147ab821dceeab6e838d34b092f101c3 
>   src/health-check/health_checker.cpp a8424b75927d15dc1b897faf0e47cf075c70ff26 
> 
> Diff: https://reviews.apache.org/r/55454/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message