mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 54898: Added a CHECK in updateFrameworkInfo.
Date Tue, 17 Jan 2017 21:30:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54898/#review161959
-----------------------------------------------------------



With respect to the comment, do you know when this check would fail?

E.g. if an agent >= 0.24.0 registers the check holds

Since by committing this I'm taking accountability of it being safe, it would be great if
you could quickly convince me that you did your homework. :)

- Benjamin Mahler


On Jan. 12, 2017, 8:57 a.m., Jay Guo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54898/
> -----------------------------------------------------------
> 
> (Updated Jan. 12, 2017, 8:57 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Guangya Liu, and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a CHECK in updateFrameworkInfo.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp 89b3c394b268a8645885412aeb19980db8d73c69 
> 
> Diff: https://reviews.apache.org/r/54898/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jay Guo
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message