mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jiang Yan Xu <...@jxu.me>
Subject Re: Review Request 55239: Stop using os::system to extract fetcher archives.
Date Tue, 17 Jan 2017 19:26:23 GMT


> On Jan. 12, 2017, 12:36 p.m., Jiang Yan Xu wrote:
> > src/launcher/fetcher.cpp, line 105
> > <https://reviews.apache.org/r/55239/diff/2/?file=1603239#file1603239line105>
> >
> >     Quote the command as well?

What about this?


> On Jan. 12, 2017, 12:36 p.m., Jiang Yan Xu wrote:
> > src/launcher/fetcher.cpp, line 113
> > <https://reviews.apache.org/r/55239/diff/2/?file=1603239#file1603239line113>
> >
> >     Quote the command as well?

What about this?


- Jiang Yan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55239/#review161409
-----------------------------------------------------------


On Jan. 13, 2017, 3:11 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55239/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2017, 3:11 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-6862
>     https://issues.apache.org/jira/browse/MESOS-6862
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Stop using os::system to extract fetcher archives.
> 
> 
> Diffs
> -----
> 
>   src/launcher/fetcher.cpp 4456c28139966e42859cc6d2c79a1d90e83fb22f 
> 
> Diff: https://reviews.apache.org/r/55239/diff/
> 
> 
> Testing
> -------
> 
> `sudo make check` (Fedora 25)
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message