mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Abhishek Dasgupta <a10gu...@linux.vnet.ibm.com>
Subject Re: Review Request 54572: Added metrics counter for scheduler calls.
Date Tue, 17 Jan 2017 18:29:03 GMT


> On Dec. 12, 2016, 9:30 p.m., Zhitao Li wrote:
> > src/master/metrics.cpp, lines 212-213
> > <https://reviews.apache.org/r/54572/diff/2/?file=1580371#file1580371line212>
> >
> >     Do we want to keep the variable and metric names match (with `/` replaced by
`_`)?

do we really want this change because other metrics will be inconsistent with these then!!


- Abhishek


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54572/#review158694
-----------------------------------------------------------


On Jan. 17, 2017, 1:05 a.m., Abhishek Dasgupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54572/
> -----------------------------------------------------------
> 
> (Updated Jan. 17, 2017, 1:05 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Benjamin Mahler, and Zhitao Li.
> 
> 
> Bugs: MESOS-6082
>     https://issues.apache.org/jira/browse/MESOS-6082
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added metrics counter for scheduler calls.
> 
> 
> Diffs
> -----
> 
>   src/master/metrics.hpp 056d290c1e14a6afd5056873ef7bb07b5892ed32 
>   src/master/metrics.cpp 1f049f3794c1bca45d2684cbbec3b08c1a78c494 
> 
> Diff: https://reviews.apache.org/r/54572/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message