mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Clemmer <>
Subject Re: Review Request 55601: CMake: Added source groups for agent.
Date Tue, 17 Jan 2017 06:41:50 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Jan. 17, 2017, 6:41 a.m.)

Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.


Fixup file matching pattern.

Bugs: MESOS-3542

Repository: mesos


This commit will continue our effort to break libmesos into a modular
set of libraries that can be built and linked independently, and away
from the approach of creating a single, monolithic libmesos library.
This effort is tracked in MESOS-3542.

This commit will specifically address the problem of breaking agent code
into a self-contained source group, which can then be exported as its
own library. This code also has the benefit of making IDEs display the
agent code in a hierarchical directory structure.

Diffs (updated)

  cmake/MesosConfigure.cmake 6a9ed9dc02f5c9a6d1fce0866f19ffeafec35cdc 
  src/CMakeLists.txt ce71afc73f85a70cd8f97a6e913662ff7ef0d94c 
  src/slave/cmake/AgentConfigure.cmake 1582127ccce773af6031a5b09252192b05a13cdc 
  src/slave/cmake/AgentSourceList.cmake PRE-CREATION 
  src/slave/container_loggers/CMakeLists.txt b46360fb1ced188102c285c914cc0d146c6db5e1 
  src/slave/qos_controllers/CMakeLists.txt 65ab338a71276a77e43af962fbc9b76e050efca6 




Alex Clemmer

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message